Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate html element id #66

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Fix duplicate html element id #66

merged 2 commits into from
Apr 3, 2020

Conversation

davidglezz
Copy link
Contributor

@davidglezz davidglezz commented Sep 23, 2019 •
edited by Matt75
Loading

Questions Answers
Description? Duplicate html element id, this module use the same as Information link in my account page
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? In My Account page, link GDPR - Personal data should have html element id psgdpr-link instead of identity-link

@PierreRambaud PierreRambaud changed the base branch from master to dev September 24, 2019 13:56
@Matt75 Matt75 changed the title Fix duplicate id Fix duplicate html element id Apr 2, 2020
@Matt75 Matt75 added the bug Something isn't working label Apr 2, 2020
@sarahdib sarahdib self-assigned this Apr 3, 2020
@Progi1984 Progi1984 merged commit 5be9b16 into PrestaShop:dev Apr 3, 2020
@Progi1984
Copy link
Member

Thanks @davidglezz

@Quetzacoalt91 Quetzacoalt91 mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
bug Something isn't working QA ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidglezz @Progi1984 @PierreRambaud @sarahdib @Matt75 @pablopolyte