Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev branch from master changes #87

Merged
merged 19 commits into from
May 28, 2020
Merged

Update dev branch from master changes #87

merged 19 commits into from
May 28, 2020

Conversation

PierreRambaud
Copy link
Contributor

No description provided.

@matks
Copy link
Contributor

matks commented May 28, 2020

Once again we will release a module with very outdated Licence headers 😭
https://github.com/PrestaShopCorp/psgdpr/blob/3f1bbcb0c84cb327cdb00f6f9914fca1b9625939/controllers/front/FrontAjaxGdpr.php#L3

I create an item to discuss it in next retrospective. It feels very wrong.

@Matt75
Copy link
Contributor

Matt75 commented May 28, 2020

Once again we will release a module with very outdated Licence headers 😭
https://github.com/PrestaShopCorp/psgdpr/blob/3f1bbcb0c84cb327cdb00f6f9914fca1b9625939/controllers/front/FrontAjaxGdpr.php#L3

I create an item to discuss it in next retrospective. It feels very wrong.

This module should use https://github.com/PrestaShop/php-dev-tools and header-stamp
php ./vendor/bin/header-stamp --license="assets/afl.txt" --exclude=".github,vendor"

We should add GitHub Actions

@matks matks mentioned this pull request May 28, 2020
Closed
@PierreRambaud
Copy link
Contributor Author

Once again we will release a module with very outdated Licence headers
https://github.com/PrestaShopCorp/psgdpr/blob/3f1bbcb0c84cb327cdb00f6f9914fca1b9625939/controllers/front/FrontAjaxGdpr.php#L3

I create an item to discuss it in next retrospective. It feels very wrong.

Should be done in a new pull request of course ^^

@matks
Copy link
Contributor

matks commented May 28, 2020

Once again we will release a module with very outdated Licence headers
https://github.com/PrestaShopCorp/psgdpr/blob/3f1bbcb0c84cb327cdb00f6f9914fca1b9625939/controllers/front/FrontAjaxGdpr.php#L3

I create an item to discuss it in next retrospective. It feels very wrong.

Should be done in a new pull request of course ^^

😅 OK but please dont release yet

I think people will laugh at us if we release such an important module with outdated license headers from 2016

@PierreRambaud PierreRambaud changed the base branch from master to dev May 28, 2020 14:56
@PierreRambaud
Copy link
Contributor Author

I change the base to update dev branch from master changes

@PierreRambaud PierreRambaud changed the title Release 1.2.0 Update dev branch from master changes May 28, 2020
@Matt75
Copy link
Contributor

Matt75 commented May 28, 2020

Once again we will release a module with very outdated Licence headers
https://github.com/PrestaShopCorp/psgdpr/blob/3f1bbcb0c84cb327cdb00f6f9914fca1b9625939/controllers/front/FrontAjaxGdpr.php#L3

I create an item to discuss it in next retrospective. It feels very wrong.

Should be done in a new pull request of course ^^

Done https://github.com/PrestaShopCorp/psgdpr/pull/88

@Progi1984 Progi1984 merged commit b3af9fb into PrestaShop:dev May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PierreRambaud @matks @Matt75 @Progi1984 @daresh @netraagal