-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Julia constants that are not exported by default #2601
Conversation
Thank for the pull request @knuesel! The change seems reasonable. I guess you left The make the build pass, you also have to run |
@RunDevelopment sorry for missing that, should be fixed now. I left |
This PR removed a few unexported constants for Julia. These constants are defined in the
Base.MathConstants
module, but they are unexported. So it should not be assumed that these names (without a module prefix) represent constants in Julia code.To illustrate, I ended up here because I was wondering why the
e
looks funny on https://docs.julialang.org/en/v1/base/arrays/#Base.hvcat . It turns out PrismJS treatse
as a Julia constant. This is wrong: by default, someone typinge
in Julia will get the errore not defined
).