Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write guide on how to provide data for new versions #283

Closed
rom1504 opened this issue May 5, 2020 · 15 comments
Closed

Write guide on how to provide data for new versions #283

rom1504 opened this issue May 5, 2020 · 15 comments
Labels

Comments

@rom1504
Copy link
Member

rom1504 commented May 5, 2020

Issuehunt badges

using the best extractors we have


IssueHunt Summary

Backers (Total: $2.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

@rom1504
Copy link
Member Author

rom1504 commented May 5, 2020

automatize as much as possible

@uncovery
Copy link
Contributor

uncovery commented May 7, 2020

I am working on a bash script that would create the whole process from scratch as much as possible. Please help to expand this: https://github.com/uncovery/minecraft_datascript

I hope this is what you mean with this issue.

So far my script can add burger data for new versions and add them to the data paths.json

I do not know how to create the protocol/versions / language files though.

@rom1504
Copy link
Member Author

rom1504 commented May 7, 2020

These are all the ways that can be used to extract data to provide minecraft data currently : https://github.com/PrismarineJS/minecraft-data/blob/master/README.md#extraction

What I mean with this issues is writing a guide that will explain what are these extractors, their benefit, what we advise to use at the current time.
It would be perfect if we could automatize everything but it's pretty much impossible due to constant changes that Mojang make.

To answer your question:

  • Language is generated using minecraft jar extractor
  • version file is simple and written manually
  • protocol file is copied from previous version then adapted manually using wiki.vg information

There is basically no way to automatize protocol.json generation (I tried)

However for everything else, there are various generators left and right. It is possible to automatize it or at least make it clear how to assemble everything.

@uncovery
Copy link
Contributor

uncovery commented May 7, 2020

Thanks, I get it now. Maybe there is a dual-purpose to my script so people not only use it, but also understand how it works through proper documentation and therefore also understand what the individual extractors' benefit is. It could then be updated to the standard that is currently advised.

I will try to continue on the script to have it do at least what I personally need from it. If anybody wants to add on to it, please be my guest.

@uncovery
Copy link
Contributor

uncovery commented May 8, 2020

You wrote:

protocol file is copied from previous version then adapted manually using wiki.vg information

so https://github.com/PrismarineJS/minecraft-jar-extractor 's protocol extractor is not really in use? or is that a different file?

@rom1504
Copy link
Member Author

rom1504 commented May 8, 2020 via email

@rom1504
Copy link
Member Author

rom1504 commented May 9, 2020

as this is evolving often and many people (like 10) have done many kind of extractor (7 maybe ?), I think a guide into all this would be useful
your autoextraction script is just another extractor (maybe a bit more powerful ?)

@uncovery
Copy link
Contributor

If you would start a draft document and put in the major sections / headlines, I would help you fill in the details.

@rom1504 rom1504 mentioned this issue Jun 28, 2020
3 tasks
@rom1504
Copy link
Member Author

rom1504 commented Aug 6, 2020

@rom1504 rom1504 pinned this issue Aug 16, 2020
@issuehunt-oss
Copy link

issuehunt-oss bot commented Oct 25, 2020

@rom1504 has funded $2.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Oct 25, 2020
@rom1504
Copy link
Member Author

rom1504 commented Nov 29, 2020

https://github.com/extremeheat/minecraft-data-extractor @extremeheat has started some work on an automated extractor including everything

@rom1504
Copy link
Member Author

rom1504 commented Mar 22, 2021

related PrismarineJS/McDataExtracting#4

@rom1504
Copy link
Member Author

rom1504 commented Apr 24, 2021

@IssueHuntBot
Copy link

@rom1504 has cancelled funding for this issue.(Cancelled amount: $2.00) See it on IssueHunt

@rom1504
Copy link
Member Author

rom1504 commented Jan 9, 2022

@rom1504 rom1504 closed this as completed Jan 9, 2022
@rom1504 rom1504 unpinned this issue Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants