Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prismarine-registry for everything #2450

Closed
10 tasks done
rom1504 opened this issue Feb 4, 2022 · 15 comments
Closed
10 tasks done

Use prismarine-registry for everything #2450

rom1504 opened this issue Feb 4, 2022 · 15 comments
Labels
refactoring Stage3 idea is precisely specified, only coding is left to do

Comments

@rom1504
Copy link
Member

rom1504 commented Feb 4, 2022

  • pblock
  • pchunk
  • pbiome
  • pchat
  • pentity
  • pitem
  • precipe
  • mineflayer
    • internal mineflayer
    • examples (should be done once other p* are done)
@rom1504
Copy link
Member Author

rom1504 commented Oct 11, 2022

Only pentity and precipe left

@rom1504
Copy link
Member Author

rom1504 commented Oct 11, 2022

Last step here is to remove all usages of minecraft-data here and instead use bot.registry
In particular everything in examples folder

@rom1504
Copy link
Member Author

rom1504 commented Oct 11, 2022

Then this will unlock using more of the dynamic features provided by packets (eg recipes)

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2022

Almost all examples done
Only mineflayer pathfinder ones left, require pathfinder support first

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2022

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2022

Maybe it would make sense in PrismarineJS/flying-squid#613 but low priority

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2022

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2022

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2022

It seems that's it, nothing else. So summary

  • Pathfinder and usage
  • prismarine-block
  • prismarine-windows
  • prismarine-viewer

Follow up will include flying-squid and prismarine-web-viewer but can be tracked in their dedicated repos and not here.

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2022

Once those are done, next step here is #2794

@rom1504
Copy link
Member Author

rom1504 commented Oct 12, 2022

@Epirito
Copy link
Contributor

Epirito commented Oct 12, 2022

Oh right I missed all static uses, mainly in tests. I'm going over all those modules again

@rom1504
Copy link
Member Author

rom1504 commented Oct 14, 2022

main thing left is prismarine-block and usage

@rom1504
Copy link
Member Author

rom1504 commented Oct 14, 2022

ah it's done already

@rom1504
Copy link
Member Author

rom1504 commented Oct 14, 2022

I'm going to call this done. Next step #2794

@rom1504 rom1504 closed this as completed Oct 14, 2022
@rom1504 rom1504 unpinned this issue Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Stage3 idea is precisely specified, only coding is left to do
Projects
None yet
Development

No branches or pull requests

2 participants