Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib/ and test/ to use prismarine-registry #2526

Merged
merged 3 commits into from
Mar 13, 2022

Conversation

extremeheat
Copy link
Member

No description provided.

@extremeheat extremeheat changed the title Update lib/ and test/ for registry Update lib/ and test/ for prismarine-registry Mar 12, 2022
@extremeheat extremeheat changed the title Update lib/ and test/ for prismarine-registry Update lib/ and test/ to use prismarine-registry Mar 12, 2022
@rom1504
Copy link
Member

rom1504 commented Mar 12, 2022

can you add bot.registry to the doc?

@rom1504
Copy link
Member

rom1504 commented Mar 12, 2022

There's a merge conflict

@rom1504
Copy link
Member

rom1504 commented Mar 12, 2022

LGTM but examples will need to be updated similarly

@rom1504
Copy link
Member

rom1504 commented Mar 12, 2022

Could be another PR

@extremeheat
Copy link
Member Author

Yeah, I didn't update the examples here for the time being to avoid confusion with some things taking/not taking the registry

@rom1504 rom1504 merged commit 9497b67 into PrismarineJS:master Mar 13, 2022
@rom1504
Copy link
Member

rom1504 commented Mar 13, 2022

ok

@rom1504
Copy link
Member

rom1504 commented Mar 13, 2022

I updated #2450
let's get this migration finished

@extremeheat extremeheat deleted the registry branch March 13, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants