Add new legacy bedrock mappings #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
extremeheat
approved these changes
Aug 19, 2023
| @@ -651,6 +651,16 @@ Example: | |||
| console.log(mcData.legacy.pc.blocks['171:15']) // Returns: 'minecraft:black_carpet' | |||
| ``` | |||
|
|
|||
| ### minecraftData.legacy.bedrock.blocks | |||
|
|
|||
| Mapping from 1.2 block:metadata to 1.18.10 block names | |||
There was a problem hiding this comment.
This should explicitly mention 1.18.10 as 1.18 is ambiguous, given some blocks were changed in 1.18.* versions. I think it'd be better to map to the version immediately after flattening, but it's not a big deal right now. Other mapping data would need to be added also for other block renames/changes, but this can be done later to keep things simple for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if the submodule automatically gets updated or not...