fix block entity set

[zardoy]

It never worked correctly.
not adding a test here as it's supposed to be used prismarine-provider-anvil obviously

[extremeheat]

If it's an exposed API there should definitely be a test, even if it's used by anvil-provider

[zardoy]

If it's an exposed API there should definitely be a test, even if it's used by anvil-provider

hm, but how do you suggest testing it without prismarine-provider-anvil? Should I just hardcode arguments in a function call in a test?

eg like

column.loadBlockEntities([
  {
    GlowingText: {
      type: "byte",
      value: 0,
    },
    keepPacked: {
      type: "byte",
      value: 0,
    },
    Color: {
      type: "string",
      value: "black",
    },
    Text4: {
      type: "string",
      value: "{\"text\":\"\"}",
    },
    x: {
      type: "int",
      value: 6,
    },
    Text3: {
      type: "string",
      value: "{\"text\":\"\"}",
    },
    y: {
      type: "int",
      value: -63,
    },
    Text2: {
      type: "string",
      value: "{\"text\":\"\"}",
    },
    z: {
      type: "int",
      value: 136,
    },
    Text1: {
      type: "string",
      value: "{\"text\":\"te\"}",
    },
    id: {
      type: "string",
      value: "minecraft:sign",
    },
  },
])

[extremeheat]

Why the removal of this comment? The blockEntities object is supposed to indeed hold entities relative to the current chunk. The chunk is not necessarily bounded to any world hence it's not supposed to hold global coordinates.

[rom1504]

this change seems incorrect since coordinates should be relative. Probably the issue is not here

[zardoy]

this change seems incorrect since coordinates should be relative. Probably the issue is not here

yes, now I see, making coordinates be relative actually makes sense so they are linked to the chunk and not the actual world holding the chunk. I will make sure to fix it properly.

I also wonder if block entities also need to be dumped (using the dump method)?