fix: underscore crate name

[EvolveArt]

Resolves #37

Changes

• Adds the replace call as mentioned in the issue's comments
• Includes corresponding unit and acceptance test

[DenuxPlays]

Does normal crates name liked normal-crate still work?
I am not sure if this is tested?

[DenuxPlays]

Unit test looks fine.
But I am missing an acceptance test.
I think we already have a test crate in the tests folder which could be extended.

[EvolveArt]

Unit test looks fine. But I am missing an acceptance test. I think we already have a test crate in the tests folder which could be extended.

Should I create another create-segment-path for instance ? or just a sub-folder ?

EDIT: the issue is on the crate name, so the only acceptance test that could be done is by creating a new test crate
EDIT 2: the tests folder doesn't seem to be compiled anywhere

[DenuxPlays]

Unit test looks fine. But I am missing an acceptance test. I think we already have a test crate in the tests folder which could be extended.

Should I create another create-segment-path for instance ? or just a sub-folder ?

EDIT: the issue is on the crate name, so the only acceptance test that could be done is by creating a new test crate

EDIT 2: the tests folder doesn't seem to be compiled anywhere

Yes just create another test crate.

I noticed this too so I already created a fix: #39

[EvolveArt]

Unit test looks fine. But I am missing an acceptance test. I think we already have a test crate in the tests folder which could be extended.

Should I create another create-segment-path for instance ? or just a sub-folder ?
EDIT: the issue is on the crate name, so the only acceptance test that could be done is by creating a new test crate
EDIT 2: the tests folder doesn't seem to be compiled anywhere

Yes just create another test crate.

I noticed this too so I already created a fix: #39

Ok so I will rebase once your fix is merged

[DenuxPlays]

@EvolveArt

PRs have been merged you can now merge main into your branch and create the acceptance test

[EvolveArt]

@EvolveArt

PRs have been merged you can now merge main into your branch and create the acceptance test

Done, you can check. Not sure if that's the best way but it does provide a correct acceptance test.
I think acceptance tests could be refactored in another PR.

[DenuxPlays]

Suggested change

	members = ["crate_segment_path", "new_crate_segment_path"]
	members = ["crate_segment_path", "folder_in_src"]

[DenuxPlays]

Suggested change

	utoipauto-lib-test-new = { path = "../new_crate_segment_path" }
	folder_in_src = { path = "../folder_in_src" }

[DenuxPlays]

Please rename the folder and the name to folder_in_src
The name is more descriptive.

Otherwise your pr looks pretty good.
Thank you for your work :)

[EvolveArt]

Please rename the folder and the name to folder_in_src The name is more descriptive.

Otherwise your pr looks pretty good. Thank you for your work :)

Done :) looking forward to help more, this crate has been really useful to simplify our utoipa doc generation

[DenuxPlays]

Looks good to me

[DenuxPlays]

Note:

I am not sure if we should introduce a "main" testing crate where we could merge all things that need to be tested across multiple crates (like this pr).
But this has nothing todo with this pr.
Just a small note from me.

Note 2:

I do have a plan for creating a larger test crate that tests multiple things maybe we can combine the ideas.

Again these notes have nothing todo with this pr!

[DenuxPlays]

@EvolveArt Could you rebase your pr one more time?
I fixed the ci a bit

[EvolveArt]

@EvolveArt Could you rebase your pr one more time? I fixed the ci a bit

done

[ProbablyClem]

Thanks guy for your work