Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate diagram IDs #801

Merged
merged 8 commits into from
Nov 14, 2019
Merged

Fix duplicate diagram IDs #801

merged 8 commits into from
Nov 14, 2019

Commits on Nov 12, 2019

  1. Add failing cypress test

    @chipit24
    chipit24 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    4a18988 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Refactor nodeIGenerator

    @chipit24
    chipit24 committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    798256e View commit details
    Browse the repository at this point in the history

  2. Convert private methods to properties due to bug

    @chipit24
    chipit24 committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    35d03e4 View commit details
    Browse the repository at this point in the history

  3. Refactor ID generator to return diagram ID as well

    @chipit24
    chipit24 committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    7cfe234 View commit details
    Browse the repository at this point in the history

  4. Change only to skip 

    Added only by mistake
    @chipit24
    chipit24 committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    214066e View commit details
    Browse the repository at this point in the history

  5. Generate unique diagram ID

    @chipit24
    chipit24 committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    5797967 View commit details
    Browse the repository at this point in the history

  6. Add nodeIdGenerator spec

    @chipit24
    chipit24 committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    2987308 View commit details
    Browse the repository at this point in the history

  7. Unskip diagram IDs test

    @chipit24
    chipit24 committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    0958cd6 View commit details
    Browse the repository at this point in the history