Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-12763: Remove "ess" environments #8

Merged
merged 9 commits into from
Dec 8, 2023
Merged

Conversation

estebangallego
Copy link
Contributor

@estebangallego estebangallego commented Dec 7, 2023

This PR addresses a critical issue related to the automatic creation of environment variables, which was occurring excessively—surpassing the limit of 100 instances. The modifications implemented in this PR effectively resolve the problem, ensuring that the generation of environment variables adheres to the intended behavior without exceeding the specified threshold. The changes made are designed to enhance the stability and performance of the system by curbing the unintended proliferation of environment variables.

Solution

  • Remove "ess" environments form the Manifests

How to Test

To validate the resolution of the issue related to excessive environment variable creation, follow these steps:

  1. Confirm that the PM Blocks package is installed in your environment.
  2. Adjust the DEFAULT_PM_BLOCKS_BRANCH from your .env to pull from this PR:
    DEFAULT_PM_BLOCKS_BRANCH=task/FOUR-12763
    
  3. Execute the sync command as per your system's specifications.
    php artisan package-pm-blocks:sync-pm-blocks
  4. Verify that the sync process is successful and inspect both the database and the UI to ensure that there are no instances of excessive ess environment variables stored.

Related Tickets & Packages

FOUR-12763

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@ryancooley ryancooley merged commit 1585893 into develop Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants