Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot save user information. when a method is not set for 2FA #6856

Merged
merged 9 commits into from
Aug 9, 2024
Merged

Cannot save user information. when a method is not set for 2FA #6856

merged 9 commits into from
Aug 9, 2024

Conversation

marcoAntonioNina
Copy link
Contributor

@marcoAntonioNina marcoAntonioNina commented May 9, 2024 •
edited by jira bot
Loading

Issue & Reproduction Steps

Cannot save user information. when a method is not set for 2FA

Solution

  • Add warning messages when method has not been set.
  • Validate when methods for 2FA are removed.

How to Test

  • Enable Two Step Authentication.
  • Select method 2FA.
  • then edit a user and save.
  • remove the method 2FA
  • try to edit user information.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

@tokensPM
Copy link

tokensPM commented May 9, 2024

QA server K8S was successfully deployed https://ci-aac7965a13.engk8s.processmaker.net

@tokensPM
Copy link

tokensPM commented May 9, 2024

QA server K8S was successfully deployed https://ci-aac7965a13.engk8s.processmaker.net

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-aac7965a13.engk8s.processmaker.net

@processmaker-sonarqube ProcessMaker SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@processmaker-sonarqube ProcessMaker SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-aac7965a13.engk8s.processmaker.net

@ryancooley ryancooley merged commit 53f8746 into next Aug 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleeli caleeli caleeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoAntonioNina @tokensPM @caleeli @ryancooley