Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Package Detection for Accessibility Integration with Userway #6866

Merged
merged 5 commits into from
May 29, 2024

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented May 21, 2024

Issue & Reproduction Steps

This PR implements detection for the accessibility package and integrates UserWay when the package is installed. The integration includes loading the appropriate scripts to display the UserWay accessibility icon on all pages, including the login page. If the accessibility package is uninstalled, the UserWay icon will no longer be displayed.

Solution

  • Add a check for the accessibility package.
  • Include UserWay scripts if the accessibility package is detected.

ci:next

How to Test

Test Case A: Verifying UserWay Integration

  1. Ensure you have a UserWay account configured.
  2. Ensure the accessibility package is installed.
  3. Install the accessibility package if not already installed.
  4. Navigate to any page within the application, including the login page.
  5. The UserWay accessibility icon should be visible on all pages.

Test Case B: Verifying UserWay Icon Removal

  1. Ensure the UserWay account is configured.
  2. Uninstall the accessibility package if not already.
  3. Navigate to any page within the application, including the login page.
  4. The UserWay accessibility icon should no longer be visible on any pages.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@mcraeteisha mcraeteisha self-requested a review May 22, 2024 17:06
Copy link
Contributor

@mcraeteisha mcraeteisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! UserWay icon appears when the accessibility package is installed and is removed when the package is unistalled.

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@sanjacornelius sanjacornelius changed the base branch from next to Epic/FOUR-15582 May 29, 2024 18:57
@sanjacornelius
Copy link
Contributor Author

Merging into epic branch Epic/FOUR-15582

@sanjacornelius sanjacornelius merged commit e95f761 into Epic/FOUR-15582 May 29, 2024
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants