Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-17003 Fix position of buttons CANCEL and SAVE #7105

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Jul 17, 2024

Issue & Reproduction Steps

The buttons were placed outside a close.
Also there is a problem when activating the configuration tab when the page is refreshed.

Solution

  • Fix the position of buttons.
  • Fix the activation rule of the Config tab.

How to Test

  • Open a process configuration
  • Go to any tab, before the fix you will see a CANCEL and SAVE button in every tab
  • With the fix the buttons are placed properly in the bottom of the config and not in every tab.
  • Go to the Configuration tab
  • Refresh the page

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@caleeli caleeli requested a review from pmPaulis July 17, 2024 16:23
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@pmPaulis
Copy link
Contributor

@caleeli
the configurations is save correctly and the buttons Save and Cancel is not showed in the other tabs, Approved!

@ryancooley ryancooley merged commit 4d8c6ec into next Jul 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants