Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-16548: Drafts being lost after renaming the screen #7113

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented Jul 18, 2024

Issue & Reproduction Steps

  • Create a new screen.
  • Add some elements to the screen
  • You can refresh your screen to validate that your changes are still there.
  • Go to the screen configuration and change the name of the screen.

Current Behavior:
All the changes will be lost

Expected Behavior:
The draft with the recent changes should still be there after renaming.

Notes for QA:
The information lost only occurs on unpublished versions. However, these changes exist in the version history as drafts before renaming the screen.

Solution

  • When saving in configuration, now we get the last version of the screen and we update the BPMN.
  • The button in configuration changed from Save to Save and publish
  • If a draft exist for the screen, when clicking in Save and publish, we show a confirmation modal to let the user decide if must continue.

How to Test

  • Create a screen.
  • Go to screen builder and do some changes (add elements), wait the autosave
  • Go to the screen configuration and change the screen name and save

Ensure the confirmation modal shows in the configuration when saving if the screen is draft

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@agustinbusso agustinbusso changed the title Bugfix/FOUR-16548 next: Bugfix/FOUR-16548: Drafts being lost after renaming the screen Jul 18, 2024
Copy link

@ryancooley ryancooley merged commit 90075a4 into next Jul 24, 2024
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants