Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the svg field by default #7141

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Exclude the svg field by default #7141

merged 1 commit into from
Jul 24, 2024

Conversation

nolanpro
Copy link
Collaborator

Issue & Reproduction Steps

The SVG for process versions was being sent with the requests API results.

NOTE: Even after excluding the svg, the change made here more than doubles the payload size. I think we should only include process_versions when they are explicitly included in the include param.

Solution

  • Exclude it by default

How to Test

Look for a smaller payload when getting the requests from api/1.0/requests

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@nolanpro nolanpro requested a review from caleeli July 22, 2024 20:38
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@caleeli
Copy link
Contributor

caleeli commented Jul 23, 2024

The following tests were completed:

  • Test save draft in modeler, saves propely the svg property (PUT /api/1.0/processes/233/draft)
  • List processes, requests, tasks
  • Open Request, Overview shows the published version diagram
  • Open task, go to Request, Overview shows the published version diagram
  • Open process, Open Slide Show, process diagram is show in the right version
  • Open process configuration, Open Testing, Run Test, go to Overview, it shows the process diagram
  • Create alternative B, the svg is also copied from A to B

@ryancooley ryancooley merged commit 8463587 into next Jul 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants