Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE- Review conclusions and work on potential fixes #7248

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

marcoAntonioNina
Copy link
Contributor

@marcoAntonioNina marcoAntonioNina commented Aug 13, 2024

Issue & Reproduction Steps

There is an error when performing an upgrade in Processmaker.
In the Cloudops team steps the Lang directory is not copied, because when the user makes their own updates to their language files, these changes are lost with the default tags that are in place.

Solution

  • A change is made in the Cloudops team steps and the Lang directory is copied but with the name Lang.orig.
  • An artisan command has also been created to synchronize those two directories and maintain the user's changes.

How to Test

  • make changes to the tags using the /admin/translations interface (saving the changes creates a lang.orig directory).
  • add new tags to the files in the 'lang.orig' directory (simulating that new tags were added by the ProcessMaker upgrade).
  • run the command php artisan processmaker:sync-translations
  • in the lang folder all the tags should be synchronized without losing the changes made by the user.

Related Tickets & Packages

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Quality Gate failed Quality Gate failed

Failed conditions

1 New Code Smells (required ≤ 0)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@ryancooley ryancooley merged commit bfda173 into next Aug 15, 2024
8 checks passed
ryancooley added a commit that referenced this pull request Aug 15, 2024
SPIKE- Review conclusions and work on potential fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants