Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python3-psutil #618

Merged
merged 23 commits into from
May 23, 2021
Merged

Add python3-psutil #618

merged 23 commits into from
May 23, 2021

Conversation

DaOfficialRolex
Copy link
Contributor

I am guessing iOS will need some patches to build correctly. For the time being this will be a draft. This is where the code fails when building for iOS.

building 'psutil._psutil_osx' extension
creating build/temp.macosx-11.0-x86_64-3.9
creating build/temp.macosx-11.0-x86_64-3.9/psutil
creating build/temp.macosx-11.0-x86_64-3.9/psutil/arch
creating build/temp.macosx-11.0-x86_64-3.9/psutil/arch/osx
cc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -O2 -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -mmacosx-version-min=11.0 -isystem /Users/haydenseay/GitHub/Procursus/build_base/darwin-amd64/1700//opt/procursus/include -isystem /Users/haydenseay/GitHub/Procursus/build_base/darwin-amd64/1700//opt/procursus/include -F/Users/haydenseay/GitHub/Procursus/build_base/darwin-amd64/1700//opt/procursus/System/Library/Frameworks -F/Users/haydenseay/GitHub/Procursus/build_base/darwin-amd64/1700//opt/procursus/Library/Frameworks -O2 -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -mmacosx-version-min=11.0 -isystem /Users/haydenseay/GitHub/Procursus/build_base/darwin-amd64/1700//opt/procursus/include -isystem /Users/haydenseay/GitHub/Procursus/build_base/darwin-amd64/1700//opt/procursus/include -F/Users/haydenseay/GitHub/Procursus/build_base/darwin-amd64/1700//opt/procursus/System/Library/Frameworks -F/Users/haydenseay/GitHub/Procursus/build_base/darwin-amd64/1700//opt/procursus/Library/Frameworks -O2 -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.4.sdk -miphoneos-version-min=14.0 -isystem /Users/rolex/Procursus/build_base/iphoneos-arm64/1700/usr/include -isystem /Users/rolex/Procursus/build_base/iphoneos-arm64/1700/usr/local/include -F/Users/rolex/Procursus/build_base/iphoneos-arm64/1700/System/Library/Frameworks -F/Users/rolex/Procursus/build_base/iphoneos-arm64/1700/Library/Frameworks -O2 -arch arm64 -miphoneos-version-min=14.0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.4.sdk -isystem /Users/rolex/Procursus/build_base/iphoneos-arm64/1700/usr/include -isystem /Users/rolex/Procursus/build_base/iphoneos-arm64/1700/usr/local/include -Wno-error-implicit-function-declaration -DPSUTIL_POSIX=1 -DPSUTIL_SIZEOF_PID_T=4 -DPSUTIL_VERSION=580 -DPSUTIL_OSX=1 -I/opt/procursus/include/python3.9 -c psutil/_psutil_common.c -o build/temp.macosx-11.0-x86_64-3.9/psutil/_psutil_common.o
clang: error: invalid argument '-mmacosx-version-min=11.0' not allowed with '-miphoneos-version-min=14.0'
clang: warning: using sysroot for 'iPhoneOS' but targeting 'MacOSX' [-Wincompatible-sysroot]
clang: error: invalid argument '-mmacosx-version-min=11.0' not allowed with '-miphoneos-version-min=14.0'
clang: warning: using sysroot for 'iPhoneOS' but targeting 'MacOSX' [-Wincompatible-sysroot]
error: command '/usr/bin/cc' failed with exit code 1
gmake[1]: *** [python-psutil.mk:18: python-psutil] Error 1
gmake: *** [Makefile:749: rebuild-python-psutil-package] Error 2

@DaOfficialRolex DaOfficialRolex marked this pull request as draft April 10, 2021 02:11
@DaOfficialRolex DaOfficialRolex mentioned this pull request Apr 13, 2021
Open
@Cryptiiiic Cryptiiiic self-assigned this Apr 18, 2021
Cryptiiiic
Cryptiiiic reviewed Apr 18, 2021
View reviewed changes
Copy link
Collaborator

@Cryptiiiic Cryptiiiic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although extremely hacky, it actually builds into a deb for iOS now.

@DaOfficialRolex
Copy link
Contributor Author

Although extremely hacky, it actually builds into a deb for iOS now.

I am seriously impressed either way. Thank you for the help!

@CRKatri
Copy link
Member

CRKatri commented Apr 18, 2021 •
edited
Loading

Remove python3.9 dep, it should not require a specific point release, if it does use dpkg version deps on the python3 package

@Cryptiiiic
Copy link
Collaborator

I'm gonna mark this as ready for review now.

@Cryptiiiic Cryptiiiic marked this pull request as ready for review April 19, 2021 09:10
Cryptiiiic
Cryptiiiic approved these changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@Cryptiiiic Cryptiiiic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ready for merging now :)

@Cryptiiiic Cryptiiiic changed the title Fixed python-psutil for macOS amd64 and arm64. iOS still in progress Add python-psutil Apr 19, 2021
@Cryptiiiic Cryptiiiic changed the title Add python-psutil Add python3-psutil Apr 19, 2021
@Diatrus Diatrus merged commit 3a21e39 into ProcursusTeam:as2 May 23, 2021
CuteNatalie pushed a commit to CuteNatalie/Procursus that referenced this pull request May 23, 2021
@DaOfficialRolex @Cryptiiiic
@Diatrus @CuteNatalie
Add python3-psutil (ProcursusTeam#618)
91b5cd9 
* Trying to add python-psutil to Procursus

* fixed a tiny error

* fixed more stuff

* Attempt ProcursusTeam#2

* Fixed python-psutil for macOS amd64 and arm64. iOS still in progress

* Fixed a packaging mistake.

* Specified copy command when packaging.

* Followed the python naming standard.

* Lowkey the hackiest hack of alltime

* Added python depends to control file.

* Removed a depends in the control file.

* Completely redesign iOS patch

* Minor fixes

* Fix macos building

* Delete ios.diff

* Update python3-psutil.mk

* Update python3-psutil.mk

Co-authored-by: Cryptiiiic <liamwqs@gmail.com>
Co-authored-by: Hayden <pinseeker75@outlook.com>
Co-authored-by: Hayden <me@diatr.us>
@DaOfficialRolex DaOfficialRolex deleted the python-psutil_darwin branch August 3, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryptiiiic Cryptiiiic Cryptiiiic approved these changes

Assignees

@Cryptiiiic Cryptiiiic

Labels
Needs Proper Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaOfficialRolex @CRKatri @Cryptiiiic @Diatrus