-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User geolocation in Google Maps #784
User geolocation in Google Maps #784
Conversation
src/GoogleMapsService.php
Outdated
@@ -273,7 +280,7 @@ public function newMapId(): string { | |||
} | |||
|
|||
public function getResourceModules( array $params ): array { | |||
return [ 'ext.maps.googlemaps3', 'ext.maps.googlemaps3ajax' ]; | |||
return [ 'ext.maps.googlemaps3', 'ext.maps.googlemaps3ajax', 'ext.maps.mylocation' ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you always load the new js file anyway, you could put it in one of the existing modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm not very familiar how script loading works in MediaWiki, but I've added it to the ext.maps.googlemaps3
module now.
Do you have a demo of this somewhere? Or a short video? |
Here: https://baugeschichte.at/Spezial:KU/ff9 |
Added: The user location setting is now remembered (local storage), so it remains active for all maps on a site. Added two new parameters:
(both of these are disabled in the demo) |
Looks good to me :) |
Fixes #98