added integration tests for SparqlLuaQueryRunner closes issue#4 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waximabbax
force-pushed
the
4-add-integration-test-sparql
branch
from
a9c8ac9
to
a7f4ac2
Compare
waximabbax
changed the title
|
manual test since its being skipped on github. |
JeroenDeDauw
reviewed
Nov 9, 2023
JeroenDeDauw
reviewed
Nov 9, 2023
| $this->assertArrayHasKey( 'results', $responseData ); | ||
| $this->assertArrayHasKey( 'bindings', $responseData['results'] ); | ||
| $this->assertCount( $limit, $responseData['results']['bindings'] ); | ||
| } |
There was a problem hiding this comment.
Interesting tests. Do they depend on test data being inserted into Blazegraph?
There was a problem hiding this comment.
They don't depend on that. It makes actual requests to the configured $sparqlEndpoint. If it's not configured, tests are skipped. Tests should ideally pass on all ENVs and platforms as long as we can make HTTP requests with the right endpoint.
There was a problem hiding this comment.
I will verify after our meeting by doing local setup
waximabbax
force-pushed
the
4-add-integration-test-sparql
branch
from
a7f4ac2
to
6c6b9b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added integration tests for SparqlLuaQueryRunner closes issue-4