Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B026 unrecommanded star-arg unpacking after a keyword argument #7261

Closed
KumoLiu opened this issue Nov 27, 2023 · 0 comments · Fixed by #7262
Closed

B026 unrecommanded star-arg unpacking after a keyword argument #7261

KumoLiu opened this issue Nov 27, 2023 · 0 comments · Fixed by #7262
Assignees
@KumoLiu
Labels
bug Something isn't working

Comments

@KumoLiu
Copy link
Contributor

KumoLiu commented Nov 27, 2023 •
edited
Loading 

/home/runner/work/MONAI/MONAI/monai/data/image_reader.py:1303:83: B026 Star-arg unpacking after a keyword argument is strongly discouraged, because it only works when the keyword parameter is declared after all parameters supplied by the unpacked sequence, and this change of ordering can surprise and mislead readers.
/home/runner/work/MONAI/MONAI/monai/inferers/inferer.py:590:21: B026 Star-arg unpacking after a keyword argument is strongly discouraged, because it only works when the keyword parameter is declared after all parameters supplied by the unpacked sequence, and this change of ordering can surprise and mislead readers.
/home/runner/work/MONAI/MONAI/tests/test_video_datasets.py:42:88: B026 Star-arg unpacking after a keyword argument is strongly discouraged, because it only works when the keyword parameter is declared after all parameters supplied by the unpacked sequence, and this change of ordering can surprise and mislead readers.
3     B026 Star-arg unpacking after a keyword argument is strongly discouraged, because it only works when the keyword parameter is declared after all parameters supplied by the unpacked sequence, and this change of ordering can surprise and mislead readers.

Refer to python/cpython#82741.
@KumoLiu KumoLiu self-assigned this Nov 27, 2023
@KumoLiu KumoLiu added the bug Something isn't working label Nov 27, 2023
KumoLiu added a commit to KumoLiu/MONAI that referenced this issue Nov 27, 2023
@KumoLiu
fix Project-MONAI#7261
8b211cf 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu mentioned this issue Nov 27, 2023
Merged
7 tasks
KumoLiu added a commit that referenced this issue Nov 27, 2023
@KumoLiu
Fix B026 unrecommanded star-arg unpacking after a keyword argument (#…
860b7c3 
…7262)

Fixes #7261

### Description
Remove star-arg unpacking before a keyword argument.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
marksgraham pushed a commit to marksgraham/MONAI that referenced this issue Jan 30, 2024
@KumoLiu @marksgraham
Fix B026 unrecommanded star-arg unpacking after a keyword argument (P…
ee68d50 
…roject-MONAI#7262)

Fixes Project-MONAI#7261

### Description
Remove star-arg unpacking before a keyword argument.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
juampatronics pushed a commit to juampatronics/MONAI that referenced this issue Mar 25, 2024
@KumoLiu @juampatronics
Fix B026 unrecommanded star-arg unpacking after a keyword argument (P…
a11d8d3 
…roject-MONAI#7262)

Fixes Project-MONAI#7261

### Description
Remove star-arg unpacking before a keyword argument.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this issue Apr 11, 2024
@KumoLiu @Yu0610
Fix B026 unrecommanded star-arg unpacking after a keyword argument (P…
e102245 
…roject-MONAI#7262)

Fixes Project-MONAI#7261

### Description
Remove star-arg unpacking before a keyword argument.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KumoLiu KumoLiu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix B026 unrecommanded star-arg unpacking after a keyword argument KumoLiu/MONAI
1 participant
@KumoLiu