Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CheckpointSaver log error #6026

Merged
merged 4 commits into from
Feb 18, 2023
Merged

Fix CheckpointSaver log error #6026

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56d4485
fix #6024
KumoLiu Feb 18, 2023
d41ca72
fix flake8
KumoLiu Feb 18, 2023
9ae38cb
fix mypy
KumoLiu Feb 18, 2023
ba40ae4
update log in exception
KumoLiu Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions monai/handlers/checkpoint_saver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from __future__ import annotations

import logging
import os
import warnings
from collections.abc import Mapping
from typing import TYPE_CHECKING, Any
Expand Down Expand Up @@ -118,6 +119,7 @@ def __init__(
self._key_metric_checkpoint: Checkpoint | None = None
self._interval_checkpoint: Checkpoint | None = None
self._name = name
self._final_filename = final_filename

class _DiskSaver(DiskSaver):
"""
Expand Down Expand Up @@ -148,7 +150,7 @@ def _final_func(engine: Engine) -> Any:

self._final_checkpoint = Checkpoint(
to_save=self.save_dict,
save_handler=_DiskSaver(dirname=self.save_dir, filename=final_filename),
save_handler=_DiskSaver(dirname=self.save_dir, filename=self._final_filename),
filename_prefix=file_prefix,
score_function=_final_func,
score_name="final_iteration",
Expand Down Expand Up @@ -271,7 +273,11 @@ def completed(self, engine: Engine) -> None:
raise AssertionError
if not hasattr(self.logger, "info"):
raise AssertionError("Error, provided logger has not info attribute.")
self.logger.info(f"Train completed, saved final checkpoint: {self._final_checkpoint.last_checkpoint}")
if self._final_filename is not None:
_final_checkpoint_path = os.path.join(self.save_dir, self._final_filename)
else:
_final_checkpoint_path = self._final_checkpoint.last_checkpoint # type: ignore[assignment]
self.logger.info(f"Train completed, saved final checkpoint: {_final_checkpoint_path}")

def exception_raised(self, engine: Engine, e: Exception) -> None:
"""Callback for train or validation/evaluation exception raised Event.
Expand All @@ -291,7 +297,11 @@ def exception_raised(self, engine: Engine, e: Exception) -> None:
raise AssertionError
if not hasattr(self.logger, "info"):
raise AssertionError("Error, provided logger has not info attribute.")
self.logger.info(f"Exception raised, saved the last checkpoint: {self._final_checkpoint.last_checkpoint}")
if self._final_filename is not None:
_final_checkpoint_path = os.path.join(self.save_dir, self._final_filename)
else:
_final_checkpoint_path = self._final_checkpoint.last_checkpoint # type: ignore[assignment]
self.logger.info(f"Exception raised, saved the last checkpoint: {_final_checkpoint_path}")
raise e

def metrics_completed(self, engine: Engine) -> None:
Expand Down