Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6522 update __format__ impl of MetaTensor #6523

Merged
merged 2 commits into from
May 17, 2023
Merged

6522 update __format__ impl of MetaTensor #6523

merged 2 commits into from
May 17, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented May 16, 2023

Fixes #6522

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli and others added 2 commits May 16, 2023 16:03
@wyli
fixes Project-MONAI#6522
ee333ea 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b2ea87e 
for more information, see https://pre-commit.ci
@wyli wyli marked this pull request as ready for review May 16, 2023 17:43
@wyli wyli requested review from Nic-Ma, KumoLiu and yiheng-wang-nv May 16, 2023 17:45
@wyli wyli enabled auto-merge (squash) May 17, 2023 06:21
@wyli
Copy link
Contributor Author

wyli commented May 17, 2023

/build

1 similar comment
@wyli
Copy link
Contributor Author

wyli commented May 17, 2023

/build

@wyli wyli merged commit 8e725aa into Project-MONAI:dev May 17, 2023
@wyli wyli deleted the 6522-metatensor-format branch May 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod left review comments

@KumoLiu KumoLiu KumoLiu approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: unsupported format string passed to MetaTensor.__format__
3 participants
@wyli @ericspod @KumoLiu