Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6612-support-mlflow-data-tracking #6616

Merged
merged 36 commits into from
Jul 19, 2023
Merged

6612-support-mlflow-data-tracking #6616

merged 36 commits into from
Jul 19, 2023

Conversation

binliunls
Copy link
Contributor

Fixes #6612 .

Description

Add the dataset tracking support to MLFlow handler.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

binliunls and others added 22 commits June 14, 2023 13:10
@binliunls
add data tracking to MLFlowHandler
093a254 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix format
e22a8d0 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
Merge branch 'Project-MONAI:dev' into 6612-support-mlflow-data-tracking
10765e7
@binliunls
log the dataset to the mlflow ui
8075f34 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix the import order issue
5f6e158 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
remove the dataset log from the complete method.
6a5e395 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
Merge branch 'Project-MONAI:dev' into 6612-support-mlflow-data-tracking
20868d0
@binliunls
fix the unit test issue
def7cc9 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix the type hint issue
b2a7482 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix the format issue
5219a6c 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
add the type hint for the input parameter
a2d857c 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix the format issue
a5a3801 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix the codeformat issue
8a3186e 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix the fl monai algo unit test issue
d0ec3bb 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
split the warning info to shorter strings
dc0d24f 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
Merge branch 'dev' into 6612-support-mlflow-data-tracking
903e442
@binliunls
Update the comments and warning messages in the code.
acd75f5 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
Add the link to PandasDataset.
f16d1ef 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
add the unit test case
93777e6 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix the format issue in the unit test
657cb0f 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
add the mlflow version requirement.
d514256 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
Merge branch 'dev' into 6612-support-mlflow-data-tracking
41f4c78
@binliunls binliunls changed the title [WIP]6612-support-mlflow-data-tracking 6612-support-mlflow-data-tracking Jun 29, 2023
@binliunls binliunls marked this pull request as ready for review June 29, 2023 16:23
@binliunls binliunls requested review from Nic-Ma and wyli June 29, 2023 16:24
@wyli wyli requested a review from ericspod July 4, 2023 13:21
Nic-Ma
Nic-Ma reviewed Jul 4, 2023
View reviewed changes
monai/bundle/utils.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Outdated Show resolved Hide resolved
tests/test_handler_mlflow.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Show resolved Hide resolved
@Nic-Ma Nic-Ma requested a review from KumoLiu July 4, 2023 13:26
KumoLiu
KumoLiu reviewed Jul 5, 2023
View reviewed changes
monai/bundle/utils.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Outdated Show resolved Hide resolved
monai/handlers/mlflow_handler.py Outdated Show resolved Hide resolved
binliunls added 6 commits July 5, 2023 08:24
@binliunls
add the skip_if_downloading_fails context manager to the test case.
58d975b 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
update mlflow handler according to the reviewers opinions.
08e31c8 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
update the test case
87edbb8 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix the format issue
0ffd97c 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
make tqdm as optional import
556618b 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix the mypy issue
9709303 
Signed-off-by: binliu <binliu@nvidia.com>
binliunls and others added 4 commits July 10, 2023 09:19
@binliunls
Remove the dataset_log parameter
83d8d6f 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
Remove the dataset log settings from the default MLFlow setting.
cf83a7e 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
fix the format issue
83ca9ff 
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
Merge branch 'dev' into 6612-support-mlflow-data-tracking
616c3ba
KumoLiu
KumoLiu approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other parts LGTM, do we need to pending this one since the experimental features? cc @wyli, @Nic-Ma, @ericspod.

@wyli
Copy link
Contributor

wyli commented Jul 19, 2023

/build

wyli
wyli approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me, could you please confirm and resolve the comments?

@wyli wyli enabled auto-merge (squash) July 19, 2023 06:52
@wyli wyli merged commit 3247db0 into Project-MONAI:dev Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@Nic-Ma Nic-Ma Nic-Ma left review comments

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the MLFlfow data tracking in MONAI
4 participants
@binliunls @wyli @Nic-Ma @KumoLiu