Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5574 Fix MBConvBlock issue in 3d #6672

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Jun 29, 2023

Fixes #5574
Closes #5695

Description

This PR is used to fix the MBConvBlock issue when spatial_dims is not 2.
The PR follows the work in:
#5695
As it was not updated after review.
Thanks @swilson314 for posting the issue!

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

yiheng-wang-nv and others added 2 commits June 29, 2023 11:36
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv requested a review from wyli June 29, 2023 04:08
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

wyli and others added 2 commits June 29, 2023 09:48
@wyli
Copy link
Contributor

wyli commented Jun 29, 2023

/build

@wyli wyli enabled auto-merge (squash) June 29, 2023 08:56
@wyli wyli disabled auto-merge June 29, 2023 08:56
@wyli wyli enabled auto-merge (squash) June 29, 2023 08:57
@wyli
Copy link
Contributor

wyli commented Jun 29, 2023

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Jun 29, 2023

/build

@wyli wyli merged commit cbf5d3f into Project-MONAI:dev Jun 29, 2023
@yiheng-wang-nv yiheng-wang-nv deleted the 5574-enable-3d-selayer branch July 3, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential 3D bug in EfficientNet Squeeze and Excitation layer
2 participants