-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4103 enhances surface Dice to use subvoxel borders #6681
Conversation
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
52eb0f5
to
831c940
Compare
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wyli . I checked the changes and this PR looks good to me. Could you address a few minor issues?
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
…lements Signed-off-by: Wenqi Li <wenqil@nvidia.com>
993325c
to
c774e92
Compare
93e6c0c
to
046b27a
Compare
thanks, the comments are addressed, I also update to use the pytorch APIs as much as possible instead of converting everything into numpy arrays. |
/build |
Fixes #4103
Description
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.