Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6725 generate properties for bundle docs #6918

Merged
merged 4 commits into from
Sep 1, 2023
Merged

6725 generate properties for bundle docs #6918

merged 4 commits into from
Sep 1, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Aug 31, 2023 •
edited
Loading

Fixes #6725

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 3 commits August 31, 2023 15:02
@wyli
update properties
7e14710 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update
bfeb61e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
style fix
126dd9e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from ericspod, Nic-Ma and KumoLiu August 31, 2023 14:33
@wyli wyli marked this pull request as ready for review August 31, 2023 14:34
KumoLiu
KumoLiu approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@wyli
Copy link
Contributor Author

wyli commented Sep 1, 2023

/build

@wyli wyli enabled auto-merge (squash) September 1, 2023 05:51
@wyli wyli merged commit e48c3e2 into Project-MONAI:dev Sep 1, 2023
29 of 32 checks passed
@wyli wyli deleted the fixes-sphinx branch September 2, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better autodoc generation -- bundle properties
2 participants
@wyli @KumoLiu