Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing SegmentDescription in PydicomReader #6937

Merged
merged 11 commits into from
Sep 4, 2023
Merged

Fix missing SegmentDescription in PydicomReader #6937

Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
64c3321
fix #6928
KumoLiu Sep 4, 2023
edd33bf
minor fix
KumoLiu Sep 4, 2023
1493b0d
minor fix
KumoLiu Sep 4, 2023
a28a423
try `SegmentLabel` first
KumoLiu Sep 4, 2023
a9cbd49
fix flake8
KumoLiu Sep 4, 2023
8691e34
Merge branch 'dev' of https://github.com/Project-MONAI/MONAI into pyd…
KumoLiu Sep 4, 2023
16bac86
try `SegmentDescription` first
KumoLiu Sep 4, 2023
6a4a980
fix flake8
KumoLiu Sep 4, 2023
8a62640
Merge branch 'dev' of https://github.com/Project-MONAI/MONAI into pyd…
KumoLiu Sep 4, 2023
591351a
address comments
KumoLiu Sep 4, 2023
a33c329
address comments
KumoLiu Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion monai/data/image_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,9 @@
all_segs = np.zeros([*spatial_shape, n_classes])

for i, (frames, description) in enumerate(self._get_frame_data(img)):
class_name = description.SegmentDescription
class_name = (

Check warning on line 769 in monai/data/image_reader.py

View check run for this annotation

Codecov / codecov/patch

monai/data/image_reader.py#L769 

Added line #L769 was not covered by tests
description.SegmentLabel if hasattr(description, "SegmentLabel") else description.SegmentDescription
)
wyli marked this conversation as resolved.
Show resolved Hide resolved
if class_name not in metadata["labels"].keys():
metadata["labels"][class_name] = i
class_num = metadata["labels"][class_name]
Expand Down
Loading