Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6976 improve config expr error msg #6977

Merged
merged 1 commit into from
Sep 13, 2023
Merged

6976 improve config expr error msg #6977

merged 1 commit into from
Sep 13, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Sep 13, 2023

Fixes #6976

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
improve config expr error msg
20f67ff 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from ericspod, Nic-Ma and KumoLiu September 13, 2023 09:28
KumoLiu
KumoLiu approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@wyli
Copy link
Contributor Author

wyli commented Sep 13, 2023

/build

@wyli wyli enabled auto-merge (squash) September 13, 2023 09:52
@wyli
Copy link
Contributor Author

wyli commented Sep 13, 2023

/build

@wyli wyli merged commit c22a2bd into Project-MONAI:dev Sep 13, 2023
27 of 32 checks passed
@wyli wyli deleted the 6976-error-msg branch September 13, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

better error message when bundle config expression has errors
2 participants
@wyli @KumoLiu