Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stats_sender to MonaiAlgo for FL stats #6984

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Add stats_sender to MonaiAlgo for FL stats #6984

merged 3 commits into from
Sep 13, 2023

Conversation

nvkevlu
Copy link
Contributor

@nvkevlu nvkevlu commented Sep 13, 2023

PR #6220 was closed and NVFlareStatsHandler has now been implemented in NVFlare in NVIDIA/NVFlare#1925. However, there is still the piece in MonaiAlgo to attach the stats_sender in initialize, so this PR adds that missing piece.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@nvkevlu nvkevlu requested a review from holgerroth September 13, 2023 19:09
@nvkevlu
Add stats_sender to MonaiAlgo for FL stats
98b2c94 
Signed-off-by: Kevin <kevlu@nvidia.com>
@nvkevlu nvkevlu force-pushed the add_fl_stats_sender branch from d9775b8 to 98b2c94 Compare September 13, 2023 19:11
yanchengnv
yanchengnv reviewed Sep 13, 2023
View reviewed changes
Copy link

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

monai/fl/client/monai_algo.py Outdated Show resolved Hide resolved
nvkevlu and others added 2 commits September 13, 2023 15:56
yanchengnv
yanchengnv approved these changes Sep 13, 2023
View reviewed changes
Copy link

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyli
Copy link
Contributor

wyli commented Sep 13, 2023

/build

@wyli wyli enabled auto-merge (squash) September 13, 2023 20:45
@wyli wyli merged commit 6dfe17a into Project-MONAI:dev Sep 13, 2023
29 of 32 checks passed
@nvkevlu nvkevlu deleted the add_fl_stats_sender branch September 13, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv approved these changes

@holgerroth holgerroth Awaiting requested review from holgerroth

@KumoLiu KumoLiu Awaiting requested review from KumoLiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvkevlu @wyli @yanchengnv