Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused kernel_size in ResBlock #6999

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Fix unused kernel_size in ResBlock #6999

merged 2 commits into from
Sep 18, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 18, 2023 •
edited
Loading

Fixes #6998

Description

Fixed unused kernel_size in ResBlock.
Fixed untested norm in unit tests.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#6998
63037a3 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
fix unittests
0f7ce72 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu requested review from wyli, ericspod and Nic-Ma September 18, 2023 10:28
wyli
wyli approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Sep 18, 2023

/build

@wyli wyli enabled auto-merge (squash) September 18, 2023 11:22
@wyli wyli merged commit 5a644e4 into Project-MONAI:dev Sep 18, 2023
25 of 30 checks passed
@KumoLiu KumoLiu deleted the resblock branch September 18, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused kernel_size in ResBlock
2 participants
@KumoLiu @wyli