Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shape check for arbitrary types for DataStats #7082

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

vgrau98
Copy link
Contributor

@vgrau98 vgrau98 commented Oct 3, 2023

Fixes #6844.

Description

DataStats was breaking for arbitrary types (other than tensor or array) because of shape attribute. Changes are made in order to be consistent with other DataStats attributes management like data_type.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Fixes: Project-MONAI#6844

DataStats was breaking for arbitrary types (other than tensor or array).

Signed-off-by: vgrau98 <victor.grau93@gmail.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Oct 3, 2023

/build

@wyli wyli enabled auto-merge (squash) October 3, 2023 20:32
@wyli wyli merged commit 65e8f5b into Project-MONAI:dev Oct 3, 2023
24 of 26 checks passed
@vgrau98 vgrau98 deleted the 6844-DataStats-input-shape branch October 3, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow different input types for DataStats transform by default
2 participants