Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autorunner params from config #7175

Merged
merged 9 commits into from
Nov 3, 2023
Merged

autorunner params from config #7175

merged 9 commits into from
Nov 3, 2023

Conversation

myron
Copy link
Collaborator

@myron myron commented Oct 30, 2023

allows setting AutoRunner params from config
allows specifying number of folds in config

@myron
autorunner params from config
43b1f75 
Signed-off-by: myron <amyronenko@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Oct 30, 2023 •
edited
Loading

/black
some issues with the integration tests

[2023-10-30T11:48:20.604Z] ======================================================================
[2023-10-30T11:48:20.604Z] ERROR: test_autorunner (__main__.TestAutoRunner)
[2023-10-30T11:48:20.604Z] ----------------------------------------------------------------------
[2023-10-30T11:48:20.604Z] Traceback (most recent call last):
[2023-10-30T11:48:20.604Z]   File "/home/jenkins/agent/workspace/Monai-notebooks/MONAI/tests/test_integration_autorunner.py", line 115, in test_autorunner
[2023-10-30T11:48:20.604Z]     runner = AutoRunner(
[2023-10-30T11:48:20.604Z]   File "/home/jenkins/agent/workspace/Monai-notebooks/MONAI/monai/apps/auto3dseg/auto_runner.py", line 238, in __init__
[2023-10-30T11:48:20.604Z]     self.export_cache()
[2023-10-30T11:48:20.604Z]   File "/home/jenkins/agent/workspace/Monai-notebooks/MONAI/monai/apps/auto3dseg/auto_runner.py", line 363, in export_cache
[2023-10-30T11:48:20.604Z]     ConfigParser.export_config_file(
[2023-10-30T11:48:20.604Z]   File "/home/jenkins/agent/workspace/Monai-notebooks/MONAI/monai/bundle/config_parser.py", line 444, in export_config_file
[2023-10-30T11:48:20.604Z]     with open(_filepath, "w") as f:
[2023-10-30T11:48:20.604Z] FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpdt5w1bbf/work_dir/cache.yaml'

@wyli wyli requested a review from mingxin-zheng October 30, 2023 11:53
@YanxuanLiu
Copy link
Collaborator

/build

@myron
Copy link
Collaborator Author

myron commented Nov 2, 2023

some issues with the integration tests

[2023-10-30T11:48:20.604Z] ======================================================================
[2023-10-30T11:48:20.604Z] ERROR: test_autorunner (__main__.TestAutoRunner)
[2023-10-30T11:48:20.604Z] ----------------------------------------------------------------------
[2023-10-30T11:48:20.604Z] Traceback (most recent call last):
[2023-10-30T11:48:20.604Z]   File "/home/jenkins/agent/workspace/Monai-notebooks/MONAI/tests/test_integration_autorunner.py", line 115, in test_autorunner
[2023-10-30T11:48:20.604Z]     runner = AutoRunner(
[2023-10-30T11:48:20.604Z]   File "/home/jenkins/agent/workspace/Monai-notebooks/MONAI/monai/apps/auto3dseg/auto_runner.py", line 238, in __init__
[2023-10-30T11:48:20.604Z]     self.export_cache()
[2023-10-30T11:48:20.604Z]   File "/home/jenkins/agent/workspace/Monai-notebooks/MONAI/monai/apps/auto3dseg/auto_runner.py", line 363, in export_cache
[2023-10-30T11:48:20.604Z]     ConfigParser.export_config_file(
[2023-10-30T11:48:20.604Z]   File "/home/jenkins/agent/workspace/Monai-notebooks/MONAI/monai/bundle/config_parser.py", line 444, in export_config_file
[2023-10-30T11:48:20.604Z]     with open(_filepath, "w") as f:
[2023-10-30T11:48:20.604Z] FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpdt5w1bbf/work_dir/cache.yaml'

I updated to latest branch, and did a small change. But I'm not sure why it can't find cache.yaml.

myron added 3 commits November 2, 2023 13:12
@myron
cache
5e8f5a3 
Signed-off-by: myron <amyronenko@nvidia.com>
@myron
Merge branch 'autorunner' of github.com:myron/MONAI into autorunner
8c97f64 
Signed-off-by: myron <amyronenko@nvidia.com>
@myron
cache
c5404c8 
Signed-off-by: myron <amyronenko@nvidia.com>
@myron
Copy link
Collaborator Author

myron commented Nov 2, 2023

Ok, I believe I fixed it, and the integration test is working

@monai-bot
[MONAI] code formatting
4c85ca4 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@wyli
Copy link
Contributor

wyli commented Nov 3, 2023

/build

@wyli
skip large test
93ad99e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Nov 3, 2023

/build

wyli
wyli approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) November 3, 2023 09:16
@wyli wyli merged commit 4847df2 into Project-MONAI:dev Nov 3, 2023
28 checks passed
marksgraham pushed a commit to marksgraham/MONAI that referenced this pull request Jan 30, 2024
@myron @marksgraham
autorunner params from config (Project-MONAI#7175)
3572fd5 
allows setting AutoRunner params from config
allows specifying number of folds in config

---------

Signed-off-by: myron <amyronenko@nvidia.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this pull request Apr 11, 2024
@myron @Yu0610
autorunner params from config (Project-MONAI#7175)
32bb745 
allows setting AutoRunner params from config
allows specifying number of folds in config

---------

Signed-off-by: myron <amyronenko@nvidia.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@mingxin-zheng mingxin-zheng Awaiting requested review from mingxin-zheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@myron @wyli @YanxuanLiu @monai-bot