-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update rm -rf /opt/hostedtoolcache
avoid change the python version
#7424
Conversation
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
/build |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Why is this directory being deleted in the original? I feel it would be helpful to add a comment at the first instance of this pattern explaining the rationale so if we come back to it like we're doing now we have a better idea of what's going on. |
Hi Eric, the original reason is the resource issue from github action. #7030 |
/build |
1 similar comment
/build |
Hi @ericspod, @yiheng-wang-nv, could you please help review it again, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
…roject-MONAI#7424) Fixes Project-MONAI#7416 ### Description update `rm -rf /opt/hostedtoolcache` avoid change the python version ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
…roject-MONAI#7424) Fixes Project-MONAI#7416 ### Description update `rm -rf /opt/hostedtoolcache` avoid change the python version ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Fixes #7416
Description
update
rm -rf /opt/hostedtoolcache
avoid change the python versionTypes of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.