Merge similar test components with parameterized #7663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Han Wang <freddie.wanah@gmail.com>
Signed-off-by: Han Wang <freddie.wanah@gmail.com>
Signed-off-by: Han Wang <freddie.wanah@gmail.com>
freddiewanah
force-pushed
the
adapt-test-parameterized
branch
from
ef582bc to
d01b61e
Compare
7 tasks
KumoLiu
reviewed
Apr 19, 2024
There was a problem hiding this comment.
Hi @freddiewanah, appreciate your contribution with the PR! Your work has indeed boosted the legibility of the testing code. I've made a few further improvement suggestions directly within the code. Thank you.
Signed-off-by: Han Wang <freddie.wanah@gmail.com>
|
Please take a look at the ci error looks forget name arg. Thanks. |
Signed-off-by: Han Wang <freddie.wanah@gmail.com>
|
Hi KumoLiu, thanks for the review, I've updated the code and now the error is fixed :) |
|
/build |
|
/build |
KumoLiu
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed some test cases contain same duplicated asserts. Having multiple asserts in one test cases can cause potential issues like when the first assert fails, the test case stops and won't check the second assert. By using @parameterized.expand, this issue can be resolved and the caching also saves execution time.
Added sign-offs from #7648
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.