Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert version requirement for mlflow #7742

Merged
merged 12 commits into from
May 10, 2024
Merged

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented May 6, 2024

Revert #7659

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@mingxin-zheng
Copy link
Contributor

Thanks @KumoLiu for PR. Just to double-check, is the previous mlflow issue resolved in all versions >=1.28.0, or just the latest versions?

@KumoLiu KumoLiu marked this pull request as draft May 6, 2024 05:42
KumoLiu added 8 commits May 6, 2024 13:47
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented May 6, 2024

Thanks @KumoLiu for PR. Just to double-check, is the previous mlflow issue resolved in all versions >=1.28.0, or just the latest versions?

Hi @mingxin-zheng, the previous issue is resolved by moving the env arg, seems not directly related to mlflow. But we have security issue with mlflow <=2.12.1.

Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KumoLiu . I believe you should have noted the security issue somewhere else. Since it's not related to this PR, we can take care of that later.

KumoLiu added 2 commits May 10, 2024 11:45
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu marked this pull request as ready for review May 10, 2024 03:48
@KumoLiu
Copy link
Contributor Author

KumoLiu commented May 10, 2024

/build

@KumoLiu KumoLiu merged commit 4af2306 into Project-MONAI:dev May 10, 2024
28 checks passed
@KumoLiu KumoLiu deleted the mlflow branch May 10, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants