Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version requirement for filelock and nni #7744

Merged
merged 7 commits into from
May 8, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented May 7, 2024

Add version requirement for filelock and nni

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu added 2 commits May 7, 2024 13:45
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
KumoLiu added 3 commits May 7, 2024 18:54
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
docs/requirements.txt Outdated Show resolved Hide resolved
@ericspod
Copy link
Member

ericspod commented May 7, 2024

We may want to change how cv2 is imported in the video_dataset.py file which is a bit of an usual workaround. It currently will import it as an option but used everywhere without checking if it's present, so having regular import statements in the methods which use it may be a better idea and get around the issue of needing cv2 to generate docs.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented May 7, 2024

We may want to change how cv2 is imported in the video_dataset.py file which is a bit of an usual workaround. It currently will import it as an option but used everywhere without checking if it's present, so having regular import statements in the methods which use it may be a better idea and get around the issue of needing cv2 to generate docs.

It's wired, opencv-python-headless is added in this PR: 1268488.
Before we don't require this package to be installed.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested a review from ericspod May 7, 2024 23:39
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now for these changes.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented May 8, 2024

/build

@KumoLiu KumoLiu merged commit f278e51 into Project-MONAI:dev May 8, 2024
28 checks passed
@KumoLiu KumoLiu deleted the filelock branch May 10, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants