Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support download bundles from ngc private registry #7907

Merged
merged 25 commits into from
Jul 17, 2024
Merged

Support download bundles from ngc private registry #7907

merged 25 commits into from
Jul 17, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jul 9, 2024

Description

Support download from ngc private registry, this download option requires ngc api key.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu and others added 11 commits July 9, 2024 17:42
@KumoLiu
support download from private registry
fd157b8 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Merge branch 'dev' of https://github.com/Project-MONAI/MONAI into sta…
1ac7d1f 
…ging-download
@KumoLiu
Merge branch 'dev' into staging-download
66b6a52
@KumoLiu
support zip download
b184692 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a1ea557 
for more information, see https://pre-commit.ci
@KumoLiu
add tests
35bdfce 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Merge branch 'dev' into staging-download
c242cc2
@KumoLiu
fix pre-commit error
b4aff81 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Merge branch 'staging-download' of https://github.com/KumoLiu/MONAI i…
ea856ce 
…nto staging-download
@KumoLiu
fix pre-commit issue
e438623 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
fix mypy
46b675f 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu marked this pull request as ready for review July 16, 2024 12:20
@KumoLiu
fix flake8
ae95599 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 16, 2024

/build

KumoLiu added 2 commits July 16, 2024 20:41
@KumoLiu
fix flake8
b9f1548 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
fix flake8
ec3b62c 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 16, 2024

/build

@mingxin-zheng
Copy link
Contributor

Please also fix the docstring here:

            In default, the value is achieved from the environment variable BUNDLE_DOWNLOAD_SRC, and
            it should be "ngc", "monaihosting", "github", or "huggingface_hub".

Thanks!

KumoLiu added 7 commits July 17, 2024 11:53
@KumoLiu
use env instead of arg
a9bd847 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
remove api_key
37681c5 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
update ci env
d7fd69d 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
update doc string
e08fa1a 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
fix flake8
ed13127 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
fix ci
1eb15cf 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
fix format
49a6244 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Nic-Ma
Nic-Ma reviewed Jul 17, 2024
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
Nic-Ma
Nic-Ma reviewed Jul 17, 2024
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
Nic-Ma
Nic-Ma approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put some comments inline to remove nvstaging naming. Others look good to me.

Thanks.

KumoLiu added 2 commits July 17, 2024 16:17
@KumoLiu
address comments
57b5d03 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
minor fix
082933b 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
address comments
cb18482 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
add comments
ac013dd 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 17, 2024

/build

@ericspod ericspod merged commit 50d5180 into Project-MONAI:dev Jul 17, 2024
28 checks passed
@KumoLiu KumoLiu deleted the staging-download branch July 19, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@ericspod ericspod ericspod approved these changes

@mingxin-zheng mingxin-zheng Awaiting requested review from mingxin-zheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KumoLiu @mingxin-zheng @ericspod @Nic-Ma @yiheng-wang-nv