Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of patch_norm to False in SwinUNETR #8249

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Dec 2, 2024

Fixes #8248

Description

Update the default value of patch_norm to False in SwinUNETR to align with the default value in SwinTransformer. This change modifies the default behavior of the model

patch_norm: bool = False,

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested review from ericspod and Nic-Ma December 2, 2024 03:29
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Dec 2, 2024

/build

monai/networks/nets/swin_unetr.py Show resolved Hide resolved
@KumoLiu KumoLiu merged commit 7f88a46 into Project-MONAI:dev Dec 2, 2024
28 checks passed
@KumoLiu KumoLiu deleted the fix-swinunetr branch December 2, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError in TestSWINUNETR
2 participants