Failing to collapse sliproad

[willwhite]

Found another case where OSRM is failing to collapse a slip road here:

https://www.mapbox.com/get-directions/#17.36/37.29941/-121.83948?coordinates=-121.83803529740746,37.299429295255706;-121.83948370888538,37.29940937280185

[miccolis]

@oxidase or @MoKob can you tell it this related to scenario 1 (the only remaining open one) on #4348 ?

[oxidase]

@miccolis atm the issue is not fixed in master. The problem is that sliproad obviousness check fails at

osrm-backend/include/extractor/guidance/intersection_handler.hpp

Lines 508 to 511 in d23a5fc

	// perfectly straight turns prevent obviousness
	const auto turn_deviation = angularDeviation(intersection[i].angle, STRAIGHT_ANGLE);
	if (turn_deviation < FUZZY_ANGLE_DIFFERENCE)
	return 0;

with

(gdb) p intersection[i].angle
$17 = 158.95050803358333
(gdb) p turn_deviation
$18 = 21.049491966416667
(gdb) p FUZZY_ANGLE_DIFFERENCE
$19 = 25

It is fixed in fix/obvious-2 branch of #4426

[oxidase]

Fixed in 5.17.0