Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review slip-road handlers #4348

Closed
12 tasks done
MoKob opened this issue Jul 27, 2017 · 2 comments
Closed
12 tasks done

Review slip-road handlers #4348

MoKob opened this issue Jul 27, 2017 · 2 comments
Assignees

Comments

@MoKob
Copy link

MoKob commented Jul 27, 2017

Scenario 1

primary via primary_link onto secondary.

screen shot 2017-07-27 at 12 48 34 2
osrm

This feels like a primary candidate for a sliproad.

  • investigate handler that discards it
  • adjust if possible
  • evaluate other affected locations

Scenario 2

tertiary via tertiary_link onto second residential.

screen shot 2017-07-27 at 12 51 59 2

osrm

Looks very similar to scenario 3, only down two road categories. Actions remain the same:

  • investigate handler that discards it
  • adjust if possible
  • evaluate other affected locations

Scenario 3

residential_road via residential_road onto residential_road

screen shot 2017-07-27 at 12 55 54 2

osrm

This one is tricky, due to no link class. Given the matching names and the short segment, we might be able to detect these.

  • investigate handler that discards it
  • adjust if possible
  • evaluate other affected locations

Scenario 4

motorway_link via motorway_link onto primary

screen shot 2017-07-27 at 12 58 30 2

osrm

This might be influenced with us treating motorways differently than normal roads.

  • investigate handler that discards it
  • adjust if possible
  • evaluate other affected locations
@oxidase
Copy link
Contributor

oxidase commented Aug 3, 2017

@MoKob in the 4th scenario sliproad handler discards the sliproad candidate at


because first road is also a motorway_link

@oxidase oxidase mentioned this issue Oct 2, 2017
4 tasks
@oxidase
Copy link
Contributor

oxidase commented Oct 9, 2017

All four cases are merged as separate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants