Enable error when GCC/clang print warning #4843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheMarex Shall I close the old one of mine? |
TheMarex
force-pushed
the
build/error_on_warn
branch
from
0cff9da to
579ca34
Compare
|
This PR is blocked by #4849 since we require a higher compiler version to trim down the false positives. |
TheMarex
force-pushed
the
build/error_on_warn
branch
from
579ca34 to
f337292
Compare
4 tasks
TheMarex
force-pushed
the
build/error_on_warn
branch
3 times, most recently
from
31f480a to
c95d4d8
Compare
|
Nice work getting this going! |
TheMarex
force-pushed
the
build/error_on_warn
branch
from
c95d4d8 to
0248b52
Compare
|
I could help cleaning/fixing warnings reported by MSVC. |
This can be removed after cjntaylor/node-cmake#37 is merged and released.
TheMarex
force-pushed
the
build/error_on_warn
branch
from
7146357 to
295d615
Compare
|
@mloskot yes a MSVC PR would be great! |
oxidase
approved these changes
Feb 9, 2018
.travis.yml
Outdated
| @@ -350,7 +350,7 @@ install: | |||
| - mkdir example/build && pushd example/build | |||
| - export PKG_CONFIG_PATH=${OSRM_INSTALL_DIR}/lib/pkgconfig | |||
| - cmake .. -DCMAKE_BUILD_TYPE=${BUILD_TYPE} | |||
| - make --jobs=${JOBS} | |||
| - make --jobs=${JOBS} VERBOSE=1 | |||
There was a problem hiding this comment.
is VERBOSE=1 needed on master or it is just a left over?
There was a problem hiding this comment.
Leftover, good catch forgot about this commit.
TheMarex
force-pushed
the
build/error_on_warn
branch
from
295d615 to
df1b06b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As replacement for this pr we are going to be a lot stricter about the warnings we do enable and will make the build fail so that we can catch it in CI.
Tasklist
Requirements / Relations
Replacement for #4495