Compute durations for table plugin at runtime #4876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoshkaj
changed the title
ghoshkaj
force-pushed
the
implement-cache
branch
from
37e891b to
9bce30d
Compare
ghoshkaj
force-pushed
the
implement-cache
branch
9 times, most recently
from
56d6d86 to
82eb4ae
Compare
ghoshkaj
force-pushed
the
implement-cache
branch
from
4a2d17c to
103242d
Compare
ghoshkaj
force-pushed
the
implement-cache
branch
2 times, most recently
from
aa7df0c to
b0bb421
Compare
ghoshkaj
force-pushed
the
implement-cache
branch
2 times, most recently
from
548d260 to
71a03a4
Compare
6 tasks
ghoshkaj
force-pushed
the
implement-cache
branch
7 times, most recently
from
03f1202 to
68cc993
Compare
ghoshkaj
force-pushed
the
implement-cache
branch
4 times, most recently
from
00546fe to
2033f68
Compare
|
A next step here is to make the size of the cache configurable in the engine_config file. |
TheMarex
reviewed
Apr 3, 2018
include/engine/unpacking_cache.hpp
Outdated
| class UnpackingCache | ||
| { | ||
| private: | ||
| boost::compute::detail::lru_cache<std::tuple<NodeID, NodeID, std::size_t>, EdgeDuration> cache; |
There was a problem hiding this comment.
Instead of using std::size_t (8 bytes) you can use unsigned char (1 byte) for exclude_index here since its maximum values is 8.
ghoshkaj
force-pushed
the
implement-cache
branch
4 times, most recently
from
ec0ea77 to
1b91354
Compare
ghoshkaj
force-pushed
the
implement-cache
branch
7 times, most recently
from
c7983bd to
0470a4e
Compare
ghoshkaj
force-pushed
the
implement-cache
branch
2 times, most recently
from
e59fdac to
4e2f6b7
Compare
6 tasks
copy dummy cache over implement retrievePackedPathFromSearchSpace calculate packed_path_from_source_to_middle debugging the retrievePackedPathFromSearchSpace function implementation adding in packed_path_from_source_to_middle cache is partway working unpack path and get duration that way the computeDurationForEdge method comment out cache clean up the code move vector creation and allocation to outside of loop hack to not return vectors on facade.GetUncompressedForwardDurations and facade.GetUncompressedReverseDurations clean up hack add exclude_index to cache key clearing cache with timestamp rebase against vectors->range pr swapped out unordered_map cache with a boost_lru implementation calculation for cache size cleaned up comment about cache size calculations unit tests cache uses unsigned char for exclude index clean up cache and unit tests pass in a hashed key to the threadlocal cache 500 mb threadlocal 2 t fixes and a rebase correct calculation
comment about cache size update unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR implements a way to compute annotations for the table plugin at runtime, specifically, the annotation of
durationsto start off with. It follows the step in the first comment in this Issue: Compute durations for table plugin at runtimeTasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?