Refactor shared memory layout to expose Block as interface #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxidase
approved these changes
Mar 14, 2018
include/storage/shared_datatype.hpp
Outdated
|
|
||
| inline uint64_t GetBlockSize(BlockID bid) const { return num_entries[bid] * entry_size[bid]; } | ||
| inline uint64_t GetBlockSize(BlockID bid) const { return blocks[bid].byte_size; } | ||
|
|
||
| inline uint64_t GetSizeOfLayout() const | ||
| { | ||
| uint64_t result = 0; | ||
| for (auto i = 0; i < NUM_BLOCKS; i++) | ||
| { | ||
| BOOST_ASSERT(entry_align[i] > 0); |
There was a problem hiding this comment.
s/entry_align[i]/blocks[i].entry_align/
TheMarex
force-pushed
the
refactor/block
branch
from
ca84aeb to
8bf8539
Compare
TheMarex
force-pushed
the
refactor/block
branch
from
8bf8539 to
48a7216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR was a first step towards #4952 that makes the interface of
DataLayoutcleaner.Tasklist