Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed segregated identification code to not mark circular edges as segregated #4968

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

dgearhart
Copy link
Contributor

@dgearhart dgearhart commented Mar 21, 2018

Issue

We missed excluding circular edges when marking segregated edges.

Tasklist

Fixed test
Before:
before_circular_ignore

After:
after_circuler_ignore

@dgearhart dgearhart self-assigned this Mar 21, 2018
@dgearhart dgearhart requested a review from oxidase March 21, 2018 15:36
@dgearhart dgearhart changed the title Fixed segregated identification code to not mark circular edges as segragted Fixed segregated identification code to not mark circular edges as segregated Mar 21, 2018
Copy link
Contributor

@oxidase oxidase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@oxidase oxidase merged commit 535bb49 into master Mar 21, 2018
@oxidase oxidase deleted the gdg_fix_segregated_indentification branch March 21, 2018 17:02
dgearhart added a commit that referenced this pull request Mar 22, 2018
Updated #4968: Updated segregated intersection identification
@dgearhart dgearhart mentioned this pull request Mar 22, 2018
oxidase pushed a commit that referenced this pull request Mar 23, 2018
Updated #4968: Updated segregated intersection identification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants