Refactor shared memory data layout to use named identifiers #4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMarex
force-pushed
the
refactor/shared_memory_addressing
branch
2 times, most recently
from
c10eded to
76f88a4
Compare
TheMarex
force-pushed
the
refactor/shared_memory_addressing
branch
2 times, most recently
from
99976aa to
21f759e
Compare
TheMarex
force-pushed
the
refactor/shared_memory_addressing
branch
2 times, most recently
from
cd326db to
995a09a
Compare
TheMarex
force-pushed
the
refactor/shared_memory_addressing
branch
from
995a09a to
00395bc
Compare
4 tasks
5 tasks
oxidase
reviewed
Mar 29, 2018
include/storage/shared_datatype.hpp
Outdated
| class DataLayout | ||
| { | ||
| public: | ||
| enum BlockID | ||
| { |
src/storage/storage.cpp
Outdated
| @@ -402,15 +313,15 @@ void Storage::PopulateData(const DataLayout &layout, char *memory_ptr) | |||
| { | |||
| const auto name_blocks_ptr = | |||
| layout.GetBlockPtr<extractor::NameTableView::IndexedData::BlockReference, true>( | |||
| memory_ptr, DataLayout::NAME_BLOCKS); | |||
| memory_ptr, "/common/names/blocks"); | |||
There was a problem hiding this comment.
It is good to move initialization into a free function as
return util::vector_view<BlockT> (layout.GetBlockPtr<BlockT, true>(memory_ptr, name), layout.GetBlockEntries(name));
to avoid duplication of type-name pairs.
include/storage/shared_datatype.hpp
Outdated
| inline std::string trimName(const std::string &name_prefix, const std::string &name) | ||
| { | ||
| // list directory and | ||
| if (name_prefix.back() == '/') |
There was a problem hiding this comment.
!name_prefix.empty() && ...
|
@oxidase Could you review this again? I refactored creating the views so it can be shared by |
oxidase
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This works towards #4952 by using the string identifiers everywhere to reference to the data. This makes
DataLayoutquite "stupid" as it does not know about the data anymore and can have a variable number of entries.Tasklist
Requirements / Relations
This PR is based on #4960.