Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase 5197 to master: Optionally cache CH/MLD edge distances #5201

Closed
wants to merge 19 commits into from

Conversation

chaupow
Copy link
Member

@chaupow chaupow commented Sep 8, 2018

Issue

This PR is #5197 but rebased to master.
I did not dare to force push to the original PR directly, being afraid to screw things up. Needs a double check whether this works and can then be force pushed onto 5197.

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@chaupow chaupow force-pushed the chaupow_danpat_rebase branch 6 times, most recently from c3edf36 to 01f050c Compare September 9, 2018 18:58
@ghoshkaj ghoshkaj force-pushed the chaupow_danpat_rebase branch from a7e606e to 1a9cb97 Compare September 14, 2018 20:35
@chaupow chaupow force-pushed the chaupow_danpat_rebase branch 3 times, most recently from e599596 to a67c686 Compare September 17, 2018 14:09
@ghoshkaj ghoshkaj force-pushed the chaupow_danpat_rebase branch 12 times, most recently from ff4662c to c7a5328 Compare September 20, 2018 00:59
@ghoshkaj ghoshkaj force-pushed the chaupow_danpat_rebase branch 7 times, most recently from 5b0a104 to 9ed768a Compare September 26, 2018 19:53
@ghoshkaj ghoshkaj force-pushed the chaupow_danpat_rebase branch from 4da5acf to bd396cd Compare October 25, 2018 21:02
danpat and others added 2 commits October 25, 2018 17:57
Prep alpha release for testing.

Remove logging.

BY ALL MEANS REVERT THIS BEFORE CONTINUING DEVELOPMENT

comments out tests to pass

DIRTY COMMIT REVERT PLX; remove all failing node tests for mld distances

change assertions and permit distance zero edges

format

bump to alpha 2

update changelog after 5.19 release (#5203)

uncomment tests

comment out test that was never run

make unit tests pass
get timzone unit tests to pass

get validation tests to pass

get updater and timezone unit test files to build with multiline string formatting

update validateFeature to validate polygon outterings and tzid

add tzid to all test fixtures of geojson features

add txid to test fixture

added tzid to hongkon test data but it already has timezone property
@ghoshkaj ghoshkaj force-pushed the chaupow_danpat_rebase branch from bd396cd to c803cef Compare October 25, 2018 21:58
ghoshkaj and others added 16 commits October 26, 2018 11:30
comment out mld tests

comment out MLD tests

why do bits of mld code keep happening?
lint

remove debugging logging

comment out cuke log file logging

redo mld progress flag
This reverts commit 3ecf673.

Revert "no mld"

This reverts commit 29464f4.

Revert "comment out MLD tests"

This reverts commit b81cc70.

Revert "uncommenting parts of test makefile"

This reverts commit de152a8.

uncomment mld data creation in test make file

uncomment a few nodejs mld tests as they pass now
… and mld

add exact number cucumber testcases
…one path

change test case to reliably choose one path for all four symmetric corners

change testcase to reliably choose one path
@ghoshkaj ghoshkaj force-pushed the chaupow_danpat_rebase branch from c803cef to 2de119d Compare October 26, 2018 15:30
@ghoshkaj ghoshkaj closed this Oct 26, 2018
@ghoshkaj ghoshkaj force-pushed the chaupow_danpat_rebase branch from 2de119d to b1791d1 Compare October 26, 2018 19:55
@ghoshkaj ghoshkaj reopened this Oct 26, 2018
@ghoshkaj ghoshkaj force-pushed the chaupow_danpat_rebase branch 2 times, most recently from 6cdb669 to c36cf18 Compare October 26, 2018 21:28
@danpat danpat closed this Oct 29, 2018
@danpat danpat deleted the chaupow_danpat_rebase branch October 29, 2018 19:12
@danpat
Copy link
Member

danpat commented Oct 29, 2018

Moved to #5251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants