Fix windows build due to missing header #5249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpat
force-pushed
the
danpat_fix_windows_1
branch
from
00e5e05 to
777c93e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little while ago, I added a fast IEEE754 renderer to speed up JSON serialization, particularly for large
tablerequests where lots of decimal numbers need to get written to a string.That change broke the Windows builds - on Windows, the
msinttypes/stdlib.hheader was needed, but it wasn't in the search path.This PR modifies the IEEE754 renderer to use the
msinttypes/stdlib.hfile that's already included with RapidJSON, so things compile on Windows again.