Fix table result when source and destination on same one-way segment #5828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjjbell
force-pushed
the
one_way_loop
branch
5 times, most recently
from
317d9c1 to
f3bfb18
Compare
Fixes Project-OSRM#5788 Table queries where source and destination are phantom nodes on the same one-way segment can fail to find valid routes. This is due to a bug in the MLD table generation for the special case where the query can be simplified to a one-to-many search. If the destination is before the source on the one-way segment, it will fail to find a route. We fix this case by not marking the node as visited at the start, so that valid paths to this node can be found later in the search. We also remove redundant initialization for the source node as the same actions are performed by a search step.
mjjbell
force-pushed
the
one_way_loop
branch
from
f3bfb18 to
0098b78
Compare
danpat
approved these changes
Oct 7, 2020
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Nov 19, 2020
- Changes from 5.22.0
- Build:
- FIXED: pessimistic calls to std::move [Project-OSRM#5560](Project-OSRM#5561)
- Features:
- ADDED: new API parameter - `snapping=any|default` to allow snapping to previously unsnappable edges [Project-OSRM#5361](Project-OSRM#5361)
- ADDED: keepalive support to the osrm-routed HTTP server [Project-OSRM#5518](Project-OSRM#5518)
- ADDED: flatbuffers output format support [Project-OSRM#5513](Project-OSRM#5513)
- ADDED: Global 'skip_waypoints' option [Project-OSRM#5556](Project-OSRM#5556)
- FIXED: Install the libosrm_guidance library correctly [Project-OSRM#5604](Project-OSRM#5604)
- FIXED: Http Handler can now deal witch optional whitespace between header-key and -value [Project-OSRM#5606](Project-OSRM#5606)
- Routing:
- CHANGED: allow routing past `barrier=arch` [Project-OSRM#5352](Project-OSRM#5352)
- CHANGED: default car weight was reduced to 2000 kg. [Project-OSRM#5371](Project-OSRM#5371)
- CHANGED: default car height was reduced to 2 meters. [Project-OSRM#5389](Project-OSRM#5389)
- FIXED: treat `bicycle=use_sidepath` as no access on the tagged way. [Project-OSRM#5622](Project-OSRM#5622)
- FIXED: fix table result when source and destination on same one-way segment. [Project-OSRM#5828](Project-OSRM#5828)
- FIXED: fix occasional segfault when swapping data with osrm-datastore and using `exclude=` [Project-OSRM#5844](Project-OSRM#5844)
- FIXED: fix crash in MLD alternative search if source or target are invalid [Project-OSRM#5851](Project-OSRM#5851)
- Misc:
- CHANGED: Reduce memory usage for raster source handling. [Project-OSRM#5572](Project-OSRM#5572)
- CHANGED: Add cmake option `ENABLE_DEBUG_LOGGING` to control whether output debug logging. [Project-OSRM#3427](Project-OSRM#3427)
- CHANGED: updated extent of Hong Kong as left hand drive country. [Project-OSRM#5535](Project-OSRM#5535)
- FIXED: corrected error message when failing to snap input coordinates [Project-OSRM#5846](Project-OSRM#5846)
- Infrastructure
- REMOVED: STXXL support removed as STXXL became abandonware. [Project-OSRM#5760](Project-OSRM#5760)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5788
Table queries where source and destination are phantom nodes on the same one-way segment can fail to find valid routes.
This is due to a bug in the MLD table generation for the special case where the query can be simplified to a
one-to-many search. If the destination is before the source on the one-way segment, it will fail to find a route.
We fix this case by not marking the node as visited at the start, so that valid paths to this node can be found later in the search.
We also remove redundant initialization for the source node as the same actions are performed by a search step.
Tasklist