Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-pre-gyp to fix Node 12/14 installation problems in some environments #5991

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

danpat
Copy link
Member

@danpat danpat commented Mar 23, 2021

Issue

needle is a HTTP client library that node-pre-gyp uses to download binaries. The version of node-pre-gyp we depended on (0.12.0) depended on an old version of needle that has this bug: tomas/needle#312 - it broke with Node 12.

For users with the request module available, this problem wasn't noticed. But in greenfield installations of npm install osrm, the following error was being encountered:

> osrm@5.24.0 install /project/node_modules/osrm
> node-pre-gyp install --fallback-to-build=false || ./scripts/node_install.sh

node-pre-gyp WARN Using needle for node-pre-gyp https download
node-pre-gyp ERR! install error
node-pre-gyp ERR! stack Error: bad download

Updating node-pre-gyp upgrades the needle dependency, and fixes the above problem.

Tasklist

@danpat danpat merged commit 5740604 into master Mar 23, 2021
@DennisOSRM DennisOSRM deleted the danpat_fix_node_pre_gyp branch November 6, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants